-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store shortcuts in config #129
base: main
Are you sure you want to change the base?
Conversation
Thanks a lot for the PR @JuliDi. Do you think we really need to make the shortcuts configurable? i.e. what other shortcut sets would make sense? |
Making them configurable might prove useful in the future if there are more actions that can have a shortcut (there might be people preferring the F-keys over arrow keys and characters etc). However, this might be my personal preference from using other programs. Regarding other shortcuts, some ideas that come to mind:
|
Are some hotkeys already specified here - but they don't seem to work (at least on Linux)? |
I can confirm that this does not work with Ubuntu 20.04, might be related to this issue: linebender/druid#281 |
I'd love to get configurable hotkeys as well. I'm using my computer without a mouse, just a keyboard. So being able to control Psst without using the mouse would be great. Few recommendations (based on vim control scheme): focus search bar: / but as mentioned before, these shortcuts should still be configurable by the user. Example usecase: I'm not using one of the usual keyboard layouts, so being able to set my own hotkeys would be great! |
@kataklasm totally agree that there should be some good default bindings and they should be configurable by the user without changing the code and compiling the crate. As far as I can tell, the issue on Linux with druid is still not resolved. |
This is a first attempt at storing keyboard shortcuts in the config, following up on #111.
Ideally, if you open the preferences now, there is a "shortcuts" tab with some default settings. For now, either a single character (like "+" or "-" for the volume controls) or a
Code
as defined by https://docs.rs/keyboard-types/0.6.1/keyboard_types/enum.Code.html can be entered.At the moment, the entries are only parsed and validated – I couldn't manage to get proper feedback (like an error message or so) back to the UI when the entered shortcut could not be parsed.
It doesn't seem very straightforward to implement those keyboard shortcuts and recording them by the user would be even better (and is on my todo list). Also, there are probably a lot of corner-cases that might be or become problematic.
So feedback on this is highly appreciated.