Adds support for rules_swift 2.x. #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/add-rules_swift-2.x-support
branch
from
f0dd0ab
to
a2d4be7
Compare
|
Yams 5.1.3 has now been released: https://github.com/jpsim/Yams/releases/tag/5.1.3 |
|
Thank you! The remaining module would be: https://github.com/drmohundro/SWXMLHash which i think was manually added to the registry as i dont see any bazel files in that repo |
luispadron
force-pushed
the
luis/add-rules_swift-2.x-support
branch
2 times, most recently
from
d8c294a
to
49b985e
Compare
luispadron
force-pushed
the
luis/add-rules_swift-2.x-support
branch
from
49b985e
to
10d32f8
Compare
luispadron
force-pushed
the
luis/add-rules_swift-2.x-support
branch
from
10d32f8
to
aee6ac9
Compare
This does force users using this version of sourcekitten to also use rules_swift because of the `swift_c_module` removal.
luispadron
force-pushed
the
luis/add-rules_swift-2.x-support
branch
from
aee6ac9
to
fd7dadd
Compare
luispadron
commented
Jul 27, 2024
| @@ -10,7 +10,7 @@ jobs: | |||
| MacOS: | |||
| strategy: | |||
| matrix: | |||
| xcode_version: ['14.3.1', '15.2', '15.3'] | |||
There was a problem hiding this comment.
The 14.3.1 job was failing on Bazel because of diff in fixtures. I'm not able to install that version on my OS. If we're okay with bumping this this should be ready now
There was a problem hiding this comment.
Yeah that's a fairly old version now, fine to remove from CI
jpsim
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does force users using this version of sourcekitten to also use rules_swift because of the
swift_c_moduleremoval.Outstanding issues:
max_compatibility_levelneeds to be updated for deps that use rules_swift2.0.0release before we can move of the release candidateRequires the following: