Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update ESLint to v9, migrate to flat config, lint dist files #2336

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 2, 2025

Dist files linting is limited to checking if they're proper ES5.

@mgol mgol added this to the 1.14.2 milestone Mar 2, 2025
@mgol mgol requested a review from fnagel March 2, 2025 22:49
@mgol mgol self-assigned this Mar 2, 2025
@mgol mgol force-pushed the eslint-upgrade branch from 81995ad to a6fcfd8 Compare March 2, 2025 22:53
@mgol
Copy link
Member Author

mgol commented Mar 2, 2025

Note: this is ready to review but it will fail linting as long as #2335 doesn't land.

@mgol mgol force-pushed the eslint-upgrade branch from a6fcfd8 to 2d91a2e Compare March 2, 2025 22:57
@timmywil
Copy link
Member

timmywil commented Mar 3, 2025

Will review after #2335 is merged

Dist files linting is limited to checking if they're proper ES5.
@mgol mgol force-pushed the eslint-upgrade branch from 2d91a2e to 016652e Compare March 3, 2025 18:00
@mgol mgol requested a review from timmywil March 3, 2025 18:09
@mgol mgol merged commit 1da395d into jquery:main Mar 3, 2025
11 checks passed
@mgol mgol deleted the eslint-upgrade branch March 3, 2025 19:15
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

mgol added a commit to mgol/jquery-ui that referenced this pull request Mar 17, 2025
The file was erroneously left in during the migration to the flat config.

Ref jquerygh-2336
mgol added a commit to mgol/jquery-ui that referenced this pull request Mar 18, 2025
The file was erroneously left in during the migration to the flat config.

Closes jquerygh-2340
Ref jquerygh-2336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants