Add markdown-beginning/end-of-line functions and markdown-special-ctrl-a/e variable
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuranari
commented
Dec 27, 2023
| (define-key newmap [remap move-beginning-of-line] nil) | ||
| (define-key newmap [remap move-end-of-line] nil) | ||
| (make-local-variable 'minor-mode-overriding-map-alist) | ||
| (push `(visual-line-mode . ,newmap) minor-mode-overriding-map-alist))) |
There was a problem hiding this comment.
syohex
reviewed
Dec 31, 2023
markdown-mode.el
Outdated
| (`(,C-a . ,_) C-a) (_ markdown-special-ctrl-a/e))) | ||
| deactivate-mark) | ||
| ;; First move to a visible line. | ||
| (if (bound-and-true-p visual-line-mode) |
There was a problem hiding this comment.
We can see visual-line-mode even if we launch emacs by emacs -Q. So I think bound-and-true-p is not necessary. In addition to that it was introduced at Emacs 24.4 and we don't support such an old version.
org-mode still uses bound-and-true-p for visual-line-mode I suppose org-mode has not updated the code for newer versions.
There was a problem hiding this comment.
@syohex Thank you for the review. I've fixed it.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functions to move to the beginning and end of lines (
markdown-beginning-of-lineandmarkdown-end-of-line), and the variablemarkdown-special-ctrl-a/e, like Org mode.I implemented it based on this version of Org mode.
Related Issue
#811
Type of Change
Checklist
make test).