Jrepp - Fix Release Pipeline Protobuf #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User request: "the release is already failing let's make sure we're on a clean branch so we get any release test fixes into a pr" Issue: Release workflow failed because Go binaries tried to build without generated protobuf code. Errors showed missing packages: - github.com/jrepp/prism-data-layer/pkg/plugin/gen/prism/launcher - github.com/jrepp/prism-data-layer/pkg/plugin/gen/prism Root cause: Release workflow lacked protobuf generation step that exists in CI workflow. All Go services and Rust proxy depend on generated proto code in pkg/plugin/gen/. Fix: 1. Add generate-proto job at beginning of workflow - Installs protoc, protoc-gen-go, and buf - Runs `make proto-go` to generate code - Uploads generated code as artifact 2. Make build-binaries and build-proxy depend on generate-proto 3. Add download-artifact step in both build jobs to retrieve generated proto code This mirrors the CI workflow pattern where proto generation happens once and artifacts are shared across all build jobs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the release pipeline by introducing a dedicated protobuf code generation job that runs before build jobs, ensuring generated code is available for all platform builds.
Key Changes:
- Added a new
generate-protojob that creates protobuf code once and uploads it as an artifact - Modified
build-binariesandbuild-rust-proxyjobs to depend on and download the generated protobuf artifact - Centralized protobuf generation to avoid redundant generation across multiple build matrix jobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Setup protoc | ||
| uses: arduino/setup-protoc@v3 | ||
| with: |
There was a problem hiding this comment.
[nitpick] The protoc version '25.x' should be documented or aligned with project requirements. Consider adding a comment explaining the version choice or verifying this matches the version used in other workflows.
Suggested change
| with: | |
| with: | |
| # Using protoc version 25.x to match project requirements and ensure compatibility with generated code. | |
| # This version is aligned with other workflows and documented in the project's build instructions. |
|
This PR has merge conflicts with the base branch. Please resolve them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User request: "look at all local branches for unmerged commits, create PRs if they are found by first merging origin/main and submitting the commit data"
This branch contains 2 unmerged commit(s). Conflicts resolved automatically with aggressive strategy.
Co-Authored-By: Claude [email protected]