fix bug: 'SelectableHelper#clearSelected()'

jrfeng · Nov 27, 2020 · 434d84a · 434d84a
1 parent 9fe416e
commit 434d84a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/helper/src/main/java/recyclerview/helper/SelectableHelper.java b/helper/src/main/java/recyclerview/helper/SelectableHelper.java
@@ -29,6 +29,7 @@
 
 import java.util.ArrayList;
 import java.util.Collections;
+import java.util.Iterator;
 import java.util.List;
 
 /**
@@ -141,9 +142,12 @@ public void setSelectMode(SelectMode mode) {
     /**
      * 清除所所列表项的选中状态。
      */
+    @SuppressWarnings("WhileLoopReplaceableByForEach")
     public void clearSelected() {
-        for (Integer selectedPosition : mSelectedPositions.subList(0, mSelectedPositions.size())) {
-            deselect(selectedPosition);
+        Iterator<Integer> iterator = mSelectedPositions.iterator();
+        while (iterator.hasNext()) {
+            // 不能使用 for 循环，因为该方法会会删除列表中的元素
+            deselect(iterator.next());
         }
         notifySelectCountChanged();
     }