Render submenu only when there are children to display - #13
Open
sniku wants to merge 1 commit into
Open
Conversation
Previously the submenu was rendered even when there were no children to display. This was happening when manuelement had "hidden" children. This patch renders the menu element with visible children the same way as elements without any children.
Owner
|
what I do not understand, if a child doesn't have any children, it should have With which version of django-CMS did you test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the submenu was rendered when there were invisible children.
This patch renders menu element with invisible children the same way
as elements without any children.