Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase secure deployment support #30

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nathanjones4323
Copy link

@nathanjones4323 nathanjones4323 commented Mar 8, 2023

This package is awesome! My only problem was that I need to persist the data with firebase, but I can't push my firestore-key.json file to GitHub for security.

This PR uses the method from this blog post to read the firebase credentials from st.secrets in addition to directly from firestore-key.json

  • Adds support for using firebase to persist analytics securely when deployed through Streamlit Cloud or self hosting
  • Adds support for nested dicts with non-string keys
  • Added to documentation on usage inside README.md
  • Tested locally with my firebase credentials
  • Display widget usage stats in pandas.DataFrame instead of a single dict

@nathanjones4323
Copy link
Author

Link to Streamlit discussion on this PR

@nathanjones4323
Copy link
Author

Resolves Issue #29

@nathanjones4323
Copy link
Author

@jrieke Let me know if you need me to update anything or have questions !

@jgieseler
Copy link

Would be really nice if this PR would be merged at some point...

@abrayne
Copy link

abrayne commented Feb 8, 2024

I would also like a solution of this kind

@444B
Copy link

444B commented Jun 30, 2024

FYI this PR was integrated into version 0.7.0 of streamlit-analytics2 downstream fork (latest version 0.7.7 at time of writing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants