Skip to content

Fix race between GC and case object construction #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrincayc merged 3 commits into from
Mar 31, 2025
Merged

Fix race between GC and case object construction #211

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ac4b31
Fix race between GC and case object construction
n1ywb-1 Mar 18, 2025
027f7d9
Change slow GC to fast preallocation
n1ywb-1 Mar 18, 2025
8a1dea5
Revert adding to globals.h
jrincayc Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions globals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,3 +674,5 @@ extern NODE *parent_list(NODE *);
extern void dbUsual(const char*);

#endif

void do_gc(BOOLEAN full);
Copy link
Owner

@jrincayc jrincayc Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Owner

@jrincayc jrincayc Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

7 changes: 5 additions & 2 deletions intern.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,14 @@ FIXNUM hash(char *s, int len) {
}

NODE *make_case(NODE *casestrnd, NODE *obj) {
NODE *new_caseobj, *clistptr;
NODE *new_caseobj, *clistptr, *tmp;

tmp = cons(NIL, NIL);
clistptr = caselistptr__object(obj);
new_caseobj = make_caseobj(casestrnd, obj);
setcdr(clistptr, cons(new_caseobj, cdr(clistptr)));
setcar(tmp, new_caseobj);
setcdr(tmp, cdr(clistptr));
setcdr(clistptr, tmp);
return(new_caseobj);
}

Expand Down