Open
Conversation
This avoids mutating libloc.c during the windows build which avoids accidentally comitting the mutated file while developing on windows. Tested on windows 11.
sgtty.h non-termios stuff non-ioctl longjmp stuff as a side-effect this fixes Linux no-graphics builds that probably helps with jrincayc#92 also helps with jrincayc#203 tested on linux mint 22 with and without WX X11 builds remain broken
tested on windows 11
jrincayc
reviewed
Mar 29, 2025
| git.c | ||
| logo_win.res | ||
| .vscode/browse.* | ||
| .* |
Owner
There was a problem hiding this comment.
Hm, I think I would rather add .????* than private space unicode characters.
Owner
There was a problem hiding this comment.
Or maybe .[!:alnum:][!:alnum:][!:alnum:][!:alnum:]* ?
Contributor
Author
There was a problem hiding this comment.
I don't have a strong opinion
| @@ -0,0 +1,111 @@ | |||
| { | |||
Owner
There was a problem hiding this comment.
I am hesitant to approve adding this files. However, I think I would be fine with adding a defaults directory or similar with them inside, so people could just copy them into the main directory.
Contributor
Author
There was a problem hiding this comment.
That works for me. It needs documentation to be really useful anyway.
I was thinking of asking if we could add a contrib directory for stuff like that.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo on #208
remind me not to pr off my master branch