Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Restructured project #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

JuanuMusic
Copy link

  • Renamed to pycrust10
  • Created setup.py to make it available to install from pip install <path>
  • Added data_path parameter to CrustModel constructor. Allows to use external files.

- Renamed to pycrust10
- Created setup.py to make it available to install from pip install <path>
- Added data_path parameter to CrustModel constructor. Allows to use external files.
- Added parameter `include_no_thickness` to to allow the inclusion of layers with thickness lower than 0.01
- Improved code.
Copy link
Owner

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Curious - what are you using this for? As far as the package name. I'm thinking maybe crustmod or crust1 or similar. Thoughts?

@JuanuMusic
Copy link
Author

Hi!
I'm currently using this as a dataset for an earthquake prediction model I'm working with Machine Learning, for my data science course

crust1 would be more descriptive I think.

If you want, I can rename the package and make a commit

@jrleeman
Copy link
Owner

Sure. I think we'll be good to merge then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants