Skip to content

Add dark theme for Android 10#105

Open
SpiritCroc wants to merge 1 commit intojruesga:masterfrom
SpiritCroc:darktheme
Open

Add dark theme for Android 10#105
SpiritCroc wants to merge 1 commit intojruesga:masterfrom
SpiritCroc:darktheme

Conversation

@SpiritCroc
Copy link
Copy Markdown
Contributor

Imported from my Substratum theme
https://github.com/SpiritCroc/DarkCroc-Android-theme

@luca020400
Copy link
Copy Markdown
Contributor

Thanks, last time I talked with Jorge he wanted the app to stay "white".
This forces the app to follow system theme, and I'm sure he would prefer a toggle for that instead.

@SpiritCroc
Copy link
Copy Markdown
Contributor Author

Right, adding a toggle shouldn't be hard, I can do that if @jruesga wants

@jruesga
Copy link
Copy Markdown
Owner

jruesga commented Apr 26, 2020

@SpiritCroc so sorry for so much delay to replay you.

TBH, I don't like to much Dark Themes in general, but if there is a good dark theme I won't opposite to merge it. Anyway, I tested your PR and I think there is still a lot of things to theme. This repo (https://github.com/Mazda--/rview/commits/master) contains more progress on top of your work, but I'm still feeling that, in both cases, many of the dark colours are not fitting properly in the screen (too really brighter and not matching with the background).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants