fix linter errors

jschneier · Aug 4, 2024 · 77c1ea0 · 77c1ea0
1 parent db37dbc
commit 77c1ea0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/storages/backends/gcloud.py b/storages/backends/gcloud.py
@@ -20,8 +20,8 @@
 
 try:
     from google import auth
-    from google.auth.transport import requests
     from google.auth.credentials import TokenState
+    from google.auth.transport import requests
     from google.cloud.exceptions import NotFound
     from google.cloud.storage import Blob
     from google.cloud.storage import Client
@@ -361,7 +361,7 @@ def _get_iam_sign_blob_params(self):
         except AttributeError:
             service_account_email = None
 
-        # sa_email has the final say of which service_account_email to be used for signing if provided
+        # sa_email has final say of service_account used to sign url if provided
         if self.sa_email:
             service_account_email = self.sa_email
 

diff --git a/tests/test_gcloud.py b/tests/test_gcloud.py
@@ -551,7 +551,7 @@ def test_iam_sign_blob_with_adc_service_account_email(self):
             storage._bucket = mock.MagicMock()
             storage.credentials = mock.MagicMock()
             # simulating adc service account email
-            storage.credentials.service_account_email = "adc_service_account_email@gmail.com"
+            storage.credentials.service_account_email = "service@gmail.com"
             # simulating access token
             storage.credentials.token = "1234"
             blob = mock.MagicMock()
@@ -574,7 +574,7 @@ def test_iam_sign_blob_with_sa_email_setting(self):
             storage._bucket = mock.MagicMock()
             storage.credentials = mock.MagicMock()
             # simulating adc service account email
-            storage.credentials.service_account_email = "adc_service_account_email@gmail.com"
+            storage.credentials.service_account_email = "service@gmail.com"
             # simulating access token
             storage.credentials.token = "1234"
             blob = mock.MagicMock()