S3Boto3Storage: add support for Cloudfront settings through OPTIONS

[PetrDlouhy]

Add support for setting "cloudfront_key_id" and "cloudfront_key" through OPTIONS

Addresses issue #1271

[jschneier]

I see, the problem is that we're running logic in get_default_settings which is probably a mistake. Also, I believe this would break support of AWS_CLOUDFRONT_KEY_ID etc.

I think we should instead:

1. Remove the checking logic from within get_default_settings and move it to __init__ just before the signer creation you added
2. Remove the creation of cloudfront_signer and stop returning it in the dict
3. Add cloudfront_key_id and cloudfront_key as return values in the dict
4. Update the creation logic to use self.cloudfront_key and self.cloudfront_signer

What do you think?

[jschneier]

Oh I see, it doesn't break the current flow it just overrides it.

[jschneier]

Yeah on second look i think this change looks good, thanks.