[sftp] Check full path for existance in ._save() and ._mkdir() #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix #1363 and the recursion problem mentioned in the issue.
The problem was related to the fact that the
.exists(self, name)
function assumes that the input is thename
and not the full path. However, in._save()
and._mkdir()
a full path instead of the name was passed to the.exists()
.To not interfere with the interface of the
.exists()
function, I introduced a._exists(self, path)
function that uses the full path instead of the name as input.I am aware that this is sort of a duplicate to what PR #1364 targets but I also wanted to "throw this solution into the ring" ;).