Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to specify additional json files to update version number #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvrana-cen81948
Copy link

This is critical feature we are missing during our application development. Our applications contains metadata file like version.json or info.json which is loaded by monitoring tool. So we can see our deployed version on monitoring dashboard.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #649 (37f6454) into main (c1a7f9e) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   97.28%   97.42%   +0.13%     
==========================================
  Files          28       28              
  Lines         590      622      +32     
  Branches       97      102       +5     
==========================================
+ Hits          574      606      +32     
  Misses          9        9              
  Partials        7        7              
Impacted Files Coverage Δ
packages/semver/src/executors/version/index.ts 98.24% <ø> (ø)
...kages/semver/src/executors/version/utils/logger.ts 100.00% <ø> (ø)
...ages/semver/src/executors/version/utils/project.ts 96.00% <100.00%> (+4.69%) ⬆️
packages/semver/src/executors/version/version.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yjaaidi
Copy link
Member

yjaaidi commented Aug 5, 2023

Hey @mvrana-cen81948 ! Thank you for the PR. This is definitely something that we want to solve with our new custom "strategy" system.

We want to let developers choose which files to update and how.

It could be a JSON file but also a YAML file or a custom format...

That said, we still don't have an ETA and we don't want people to be stuck either.

@edbzn maybe we could add the option and mark it as "experimental"? This way, we wouldn't have to maintain it for long once the custom strategy system is out.

@edbzn edbzn force-pushed the main branch 2 times, most recently from e2d4357 to 369d933 Compare February 22, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants