Skip to content

Conversation

MartinKolarik
Copy link
Member

No description provided.

Copy link

coderabbitai bot commented Sep 19, 2025

Walkthrough

This change updates logging only in three places and adds a new config property. In src/helper/api-error-handler.ts the connectError path now logs the outdated probe restart message at info (previously debug) and otherwise retains the same exit/disconnect/retry behavior. In src/probe.ts several event logs were reworded and their levels adjusted (probe:sigkill -> info; measurement request formatting tweaked; SIGTERM -> info; SIGTERM timeout -> warn) with no control-flow changes. In config/e2e-api-test.cjs a new exported configuration property was added: server.session.cookieSecret = 'xxx', expanding the module.exports shape.

Suggested reviewers

  • emmakhute65-source

Poem

Logs rise in tone, the messages sway 📣
Info steps up where debug once lay
A secret lands in config's keep 🔐
Same exits, same paths, no promises to leap
Quiet changes hum as the system stays

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning There is no pull request description provided, so the repository lacks any narrative explaining the intent or notable side effects of the changeset. Please add a brief description summarizing the purpose of the refactor, explicitly note the files changed and the logging-level adjustments, and state whether the new exported config property server.session.cookieSecret in config/e2e-api-test.cjs is intentional or should be moved to a separate PR; include any compatibility or migration notes if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "refactor: adjust log levels" concisely states the primary intent of the changeset (adjusting log levels) and is specific enough for history scanning without excessive detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch log-levels

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df99291 and 88eebb6.

📒 Files selected for processing (1)
  • config/e2e-api-test.cjs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Test code / Run tests (18.x)
  • GitHub Check: Test code / Run e2e tests (20.x)
  • GitHub Check: Test code / Run tests (20.x)
  • GitHub Check: Test code / Run tests (22.x)
  • GitHub Check: Test docker / Publish Docker image
  • GitHub Check: Test code / Run tests (22.x)
  • GitHub Check: Test code / Run e2e tests (20.x)
  • GitHub Check: Test code / Run tests (20.x)
  • GitHub Check: Test code / Run tests (18.x)
  • GitHub Check: Test docker / Publish Docker image
🔇 Additional comments (1)
config/e2e-api-test.cjs (1)

2-6: Use a strong, env-overridable cookie secret for E2E tests

Replace the weak literal 'xxx' with an env override and a long test-only default (file: config/e2e-api-test.cjs).

Apply this diff:

-			cookieSecret: 'xxx',
+			// Prefer env override in CI; long default to satisfy libs that require >=32 bytes.
+			cookieSecret: process.env.E2E_COOKIE_SECRET || 'globalping-e2e-test-secret-5e0f8c46e9a64fabbaf3d2e0b971e5f5',

Repo scan: cookieSecret only appears in config/e2e-api-test.cjs and no server/session libs were detected — set E2E_COOKIE_SECRET in CI and confirm your config merging won't overwrite this value.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MartinKolarik MartinKolarik merged commit 8cc84bb into master Sep 21, 2025
13 checks passed
@MartinKolarik MartinKolarik deleted the log-levels branch September 21, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant