Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow reusing measurement IDs for selecting same group of probes #453

Merged
merged 25 commits into from
Dec 11, 2023

Conversation

alexey-yarmosh
Copy link
Member

Fixes #430

src/lib/geoip/providers/ip2location.ts Show resolved Hide resolved
src/measurement/store.ts Show resolved Hide resolved
src/probe/sockets-location-filter.ts Show resolved Hide resolved
src/probe/types.ts Show resolved Hide resolved
test/tests/unit/measurement/store.test.ts Outdated Show resolved Hide resolved
@alexey-yarmosh
Copy link
Member Author

I think we should additionally inform users that while they can create measurement without waiting for the prev to finish, measurement ids are not stored forever and shouldn't be hardcoded. Instead they should be rotated, ideally after every measurement finish.

@MartinKolarik
Copy link
Member

I think we should additionally inform users that while they can create measurement without waiting for the prev to finish, measurement ids are not stored forever and shouldn't be hardcoded. Instead they should be rotated, ideally after every measurement finish.

I was thinking about that, too. Will add it then.

@jimaek jimaek mentioned this pull request Dec 6, 2023
@MartinKolarik
Copy link
Member

Also I think this is missing?

Additionally, if locations.length === 1 and it's magic, and it doesn't match anything, as the last step, we should try to interpret it as a measurement ID as well. This will allow users to paste the ID into any of our tools that support the magic mode.

@MartinKolarik MartinKolarik merged commit 92ea2cf into master Dec 11, 2023
2 checks passed
@MartinKolarik MartinKolarik deleted the reusing-mes-id branch December 11, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reusing measurement IDs for selecting same group of probes
2 participants