feat: only consider cities from the most likely country #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, we run into a case where we get multiple cities that are different but close to each other, and then one somewhere far, reported by two providers, e.g.:
Sometimes each provider returns a different city, but multiple agree on the country:
We currently don't consider at all how close or far the cities are, and doing so makes sense and does improve the results a little. I initially considered clustering the cities by distance based on coordinates, but this is easier and seems to work just as well.