put back removed ng-href into dropdown menu

jseppi · Oct 27, 2014 · 6c41c92 · 6c41c92
1 parent c97b0dc
commit 6c41c92
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/angular-dropdowns.js b/angular-dropdowns.js
@@ -105,7 +105,7 @@ dd.directive('dropdownMenu', ['$parse', '$compile', 'DropdownService', '$window'
         $scope.labelField = $attrs.dropdownItemLabel || 'text';
 
         // Does not register touchstart events outside of directive scope.
-        var $clickEvent = ('click'||'touchstart'in $window);
+        var $clickEvent = ('click'||'touchstart' in $window);
         var $template = angular.element([
           '<ul class="dropdown">',
             '<li ng-repeat="item in dropdownMenu"',
@@ -172,6 +172,7 @@ dd.directive('dropdownMenuItem', [
         '<li ng-class="{divider: dropdownMenuItem.divider}">',
           '<a href="" class="dropdown-item"',
           ' ng-if="!dropdownMenuItem.divider"',
+          ' ng-href="{{dropdownMenuItem.href}}"',
           ' ng-click="selectItem()">',
             '{{dropdownMenuItem[dropdownItemLabel]}}',
           '</a>',

diff --git a/dist/angular-dropdowns.js b/dist/angular-dropdowns.js
@@ -105,7 +105,7 @@ dd.directive('dropdownMenu', ['$parse', '$compile', 'DropdownService', '$window'
         $scope.labelField = $attrs.dropdownItemLabel || 'text';
 
         // Does not register touchstart events outside of directive scope.
-        var $clickEvent = ('click'||'touchstart'in $window);
+        var $clickEvent = ('click'||'touchstart' in $window);
         var $template = angular.element([
           '<ul class="dropdown">',
             '<li ng-repeat="item in dropdownMenu"',
@@ -172,6 +172,7 @@ dd.directive('dropdownMenuItem', [
         '<li ng-class="{divider: dropdownMenuItem.divider}">',
           '<a href="" class="dropdown-item"',
           ' ng-if="!dropdownMenuItem.divider"',
+          ' ng-href="{{dropdownMenuItem.href}}"',
           ' ng-click="selectItem()">',
             '{{dropdownMenuItem[dropdownItemLabel]}}',
           '</a>',

diff --git a/dist/angular-dropdowns.min.js b/dist/angular-dropdowns.min.js