meteor 1.8 support #122
meteor 1.8 support #122
Conversation
…4. Switched from debian jessie to stretch. Install stretch version of gosu 1.10 instead of building from source.
…ion. Removed circleci code.
|
Hey @sebastianlutter, thanks for the work here! However, I can't merge this as it is right now because you've deleted several scripts and the entire CI build directory. I realize that's probably for your own builds of your repo, but that stuff is how the automated releases happen in this repo. If you can revert those changes, I'd be happy to get your Meteor-related updates merged. Related... once I find the free time, I'm going to do a complete rewrite of this project to be more flexible with build caching and Meteor/Node versions. For as long as this project has existed, the latest release only tends to support a few versions of Meteor before things break. I'd like to change that so it isn't such an ongoing maintenance burden for everyone. But first, I'll settle for just getting things working with the latest version of Meteor. :) |
|
Now only the meteor 1.8 relevant changes are part of my master. I added my email into Dockerfiles MAINTAINER, keep or remove it as you like. Looking forward for a v2.3.1 release :) Once I find free time . . . I know this very well ;) If you start your rewrite feel free to drop me a line, depending on my workload I'm willing to help best |
|
Now I am using meteor 1.9 with this package so this pull request seems to outdated. I propose merge or close it. |
| @@ -47,7 +47,7 @@ ONBUILD ARG TOOL_NODE_FLAGS | |||
| ONBUILD ENV TOOL_NODE_FLAGS $TOOL_NODE_FLAGS | |||
|
|
|||
| # optionally custom apt dependencies at app build time | |||
| ONBUILD RUN if [ "$APT_GET_INSTALL" ]; then apt-get update && apt-get install -y $APT_GET_INSTALL; fi | |||
| ONBUILD RUN if [ "$APT_GET_INSTALL" ]; then apt-get update && apt-get install -y apt-transport-https && apt-get install -y $APT_GET_INSTALL; fi | |||
There was a problem hiding this comment.
apt-transport-https can be installed by APT_GET_INSTALL, it is not required
| @@ -1,14 +1,14 @@ | |||
| FROM debian:jessie | |||
| MAINTAINER Jeremy Shimko <[email protected]> | |||
| FROM debian:stretch | |||
There was a problem hiding this comment.
debian:stable is best sollution
| gosu nobody true | ||
|
|
||
| apt-get purge -y --auto-remove wget | ||
| apt-get install -y --no-install-recommends curl bzip2 bsdtar build-essential python git gosu |
There was a problem hiding this comment.
I think this is ok, but asked community:
Hi,
the current version does not support meteor 1.8. I got into trouble when I used npm bcrypt 3.0.2 with meteor-launchpad-2.3.0, binary API is incompatible with bcrypt shared object (lazy loading error).
With nodejs and mongo version updated everything is fine again. I also switched to debian stretch, and installed gosu from debian package (1.10 as the one you installed manually before)
Merge my changes if you like, and maybe release a new version 2.3.1 of your meteor launchpad so I do not need to use my own docker image :)