-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux/windows keybindings #43
base: master
Are you sure you want to change the base?
Conversation
+1 for platform-agnostic keybindings |
Agree that |
I noticed that they keybinding-resolver package uses these CSS classes to do platform-specific bindings:
I wonder if we could do something similar? |
I hope to be able to restore this, but right now it conflicts with a whole slew of keybindings in Atom on the Mac.
I'm going to address this in #66. Would you mind rebasing this PR on that branch? I'll merge it there and probably make a bunch of changes for Windows and Mac, as well. |
keymaps/terminal.json
Outdated
"alt-shift-t": "terminal:open" | ||
}, | ||
".platform-win32 terminal-view": { | ||
"ctrl-c": "terminal:copy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to bind to Ctrl-C on Windows, as that's a standard shortcut for interrupting a program when running in a terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
82f753c
to
e3f6bc6
Compare
What's the status of this? |
Add alt-shift-t keybinding to open terminal.
It allows non mac user to open terminal with keybinding.
It could help with #6 if we remove cmd-shift-t.