Add service to allow other plugins to open terminal #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/terminal-session.js
|
From: #77 (comment)
This is a terrible excuse, but exposing xterm to other plugins on Atom doesn't feel like much more of an security concern because Atom doesn't treat it as a threat. If a user has been infected with malicious code running inside Atom, there are other facilities to run arbitrary programs/execute arbitrary scripts (BufferedProcess, ChildProcess). |
|
Any update here? |
edjubuh
added a commit
to purduesigbots/atom-bootstrapper
that referenced
this pull request
Aug 28, 2018
- Deprecate usage of build plugin since it's not maintained and won't install for users (noseglid/atom-build#569) - Use terminal-tab-plus over terminal-tab for the service (jsmecham/atom-terminal-tab#85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #77 in favor of this.
This PR adds the ability to allow other plugins to consume a
terminal-tabservice and create Terminals using this plugin.Some use cases: