Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secrets from test files #286

Merged
merged 21 commits into from
Jun 21, 2023
Merged

Remove secrets from test files #286

merged 21 commits into from
Jun 21, 2023

Conversation

jsolly
Copy link
Owner

@jsolly jsolly commented Jun 21, 2023

Description

Remove secrets from CI

Changes Made

  • Added new feature
  • Fixed bug
  • Refactored code
  • Other (please describe):

Test Plan

If the build passes

Checklist

  • I have read the contributing guidelines
  • I have added tests to cover my changes and they all pass in addition to the existing tests.
  • I have added documentation for my changes.

Additional Information

Github blocks sharing secrets with PRs created from forks

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

Because these secrets are not actually secrets (only used for CI), I am experimenting with just using plaintext for these variables.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jsolly jsolly changed the title wip Remove secrets from test files Jun 21, 2023
@jsolly jsolly merged commit c06dc1b into master Jun 21, 2023
@jsolly jsolly deleted the refactor-ci-remove-secrets branch June 21, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant