Add Jeremy Fiel as an ambassador #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfiel
force-pushed
the
feat/add-jeremy-fiel-ambassador
branch
from
9eeb861 to
5d14a39
Compare
jeremyfiel
force-pushed
the
feat/add-jeremy-fiel-ambassador
branch
from
5d14a39 to
d6f0be9
Compare
Julian
approved these changes
Aug 22, 2024
benjagm
approved these changes
Aug 22, 2024
I just fixed it to make things easier. |
gregsdennis
reviewed
Aug 22, 2024
Comment on lines
+312
to
+329
| { | ||
| "type": "other", | ||
| "title": "JSON Schema Slack Community Member", | ||
| "date": { | ||
| "year": 2021, | ||
| "month": "November" | ||
| }, | ||
| "link": "https://json-schema.slack.com" | ||
| }, | ||
| { | ||
| "type": "other", | ||
| "title": "JSON Schema Stack Overflow Community Member", | ||
| "date": { | ||
| "year": 2021, | ||
| "month": "November" | ||
| }, | ||
| "link": "https://stackoverflow.com/questions/tagged/json-schema" | ||
| }, |
There was a problem hiding this comment.
I wonder if we need a "community presence" field for these. This seems common enough to warrant its own field.
There was a problem hiding this comment.
I wonder if we need a "community presence" field for these. This seems common enough to warrant its own field.
I just created a PR to add a new value in the enum referring to Community contributions:
Some of the prior entries violated the enums and the formatting was incorrect |
mwadams
approved these changes
Aug 22, 2024
jviotti
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if I need anything further.
thanks
Jeremy