Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions: updated installation method of landscape & added conditional Statement #12

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

aialok
Copy link
Member

@aialok aialok commented Apr 26, 2024

Closes : #11

Changes:

  • Updated landscape installation method now it is more faster and fix its failures.
  • Added Conditional statement to deploy build on cloudflare only on push or workflow_dispatch with respect to main branch.

@DarhkVoyd
Copy link
Member

I think I would be better to have this into two separate workflows.

@aialok
Copy link
Member Author

aialok commented Apr 27, 2024

I think I would be better to have this into two separate workflows.

Yes, it would be better to run this in two separate workflow.
But there is not that much complex things we are doing in the workflow. We can go with this for now.

Maybe we can change this in second iteration.

cc : @benjagm your thoughts on this.

@benjagm benjagm merged commit e319233 into json-schema-org:main Apr 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Error in the pipeline of the PR #10
3 participants