Skip to content

fixed mobile blog card#1319

Merged
benjagm merged 3 commits intojson-schema-org:mainfrom
cbum-dev:mobile-card-fix
Mar 4, 2025
Merged

fixed mobile blog card#1319
benjagm merged 3 commits intojson-schema-org:mainfrom
cbum-dev:mobile-card-fix

Conversation

@cbum-dev
Copy link
Copy Markdown
Contributor

@cbum-dev cbum-dev commented Jan 17, 2025

What kind of change does this PR introduce?

Issue Number:

Screenshots/videos:
Earlier-
image

Now-
image

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@cbum-dev cbum-dev requested a review from a team as a code owner January 17, 2025 12:36
@cbum-dev
Copy link
Copy Markdown
Contributor Author

cbum-dev commented Jan 17, 2025

Hi @DhairyaMajmudar any approval of what design should I go for?
Discussion here-> #1280

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 5cc351c

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (42f23bd) to head (5cc351c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1319   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          387       387           
  Branches       103       103           
=========================================
  Hits           387       387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbum-dev
Copy link
Copy Markdown
Contributor Author

What kind of change does this PR introduce?

Issue Number:

* Closes #1280 

* Waiting for approval to work on second part, which is readability

Screenshots/videos: Earlier- image

Now- image

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DhairyaMajmudar
Copy link
Copy Markdown
Member

@cbum-dev pls. don't open PR without issues assign and follow our community guidelines.

@cbum-dev
Copy link
Copy Markdown
Contributor Author

Hi @DhairyaMajmudar, This PR is actually a fix for issue #1280. Initially, I made a typo, which I later corrected, but the update wasn't reflected here. Since #1280 was assigned to me, this PR is directly related to that issue.
Please take a look. Thanks!

@DhairyaMajmudar
Copy link
Copy Markdown
Member

Hi @DhairyaMajmudar, This PR is actually a fix for issue #1280. Initially, I made a typo, which I later corrected, but the update wasn't reflected here. Since #1280 was assigned to me, this PR is directly related to that issue. Please take a look. Thanks!

Your PR description to pointing to issue #1277 pls. enter correct issue number.

@cbum-dev
Copy link
Copy Markdown
Contributor Author

Hi @DhairyaMajmudar any approval of what design should I go for?
Discussion here-> #1280

Done, and look at this also.

@DhairyaMajmudar
Copy link
Copy Markdown
Member

It seems like your branch is too behind the upstream main branch because I'm not able to see the latest GSoC blog in the preview link.

image

@cbum-dev
Copy link
Copy Markdown
Contributor Author

cbum-dev commented Feb 1, 2025

I'll fix it.

Copy link
Copy Markdown
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit c0064b8 into json-schema-org:main Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Too much space and text readability issue.

4 participants