Pro help design #1451
Merged
Pro help design #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thund3rHawk
suggested changes
Mar 3, 2025
jdesrosiers
requested changes
Mar 3, 2025
|
Sure, I suggested because I thought that it would look good but the lots of unnecessary spaces in between words is looking wired. |
|
@jdesrosiers I changed it back |
jdesrosiers
requested changes
Mar 3, 2025
|
@jdesrosiers Thanks for the quick reply! It’s fixed now. |
|
Hoping to see a review from @json-schema-org/web-team before merging. |
|
Congratulations, @idanidan29 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR improves the card design on the Pro-Help page to ensure a visually appealing and user-friendly experience across dark mode, light mode, desktop, and mobile. The updated design enhances readability and ensures consistency across different viewing environments.
Closes #1387, Closes #1289
Screenshots/videos:
and for mobile:
Summary
This PR improves the card design on the Pro-Help page, enhancing the overall appearance and ensuring that it works well across all conditions, including dark mode, light mode, desktop, and mobile. The update aims to make the cards more visually attractive and user-friendly.
Big thanks to @Thund3rHawk for providing valuable feedback and being a part of the design suggestions.
This design has been discussed in Slack and has been approved by @jdesrosiers
Does this PR introduce a breaking change?
no