-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixed]: Navbar Active State Not Highlighting Docs and Specification related pages #1537
base: main
Are you sure you want to change the base?
[Fixed]: Navbar Active State Not Highlighting Docs and Specification related pages #1537
Conversation
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
1 similar comment
Hi @KajalMishra-29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
@benjagm |
Hi @KajalMishra-29 this issue was assigned to me. Please read the community guidelines. |
Hi @cbum-dev, I apologize for the confusion—I didn't realize the issue was assigned to you. I went ahead and resolved it, but if there's anything you'd like me to adjust or review, just let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@KajalMishra-29 But pls. take care from next time to not to open PRs for already issues, Thanks!
Thanks for the feedback, @DhairyaMajmudar! I’ll be more careful next time. |
Changes made by her dont actually do the full job. For doing that either we have to put here all the urls or put all the blogs in the same folder. |
What's your take in this @DhairyaMajmudar |
@cbum-dev I guess the approach you're suggesting would require modifying the code in multiple places. To avoid that, I opted for a shorter alternative by leveraging the fact that in the |
What kind of change does this PR introduce?
Issue Number:
Screenshots



If relevant, did you update the documentation?
N/A
Summary
isActive
condition only checked if therouter.asPath
started with/docs
or/specification
, which did not account for related subpages like/overview/...
or/draft/....
Changes Made
isActiveNav
condition to include relatedsubpaths
:/overview/...
as part of the "Docs" section./draft/...
as part of the "Specification" section.Does this PR introduce a breaking change?
No