Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to new JVM validator benchmark #225

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

big-andy-coates
Copy link
Contributor

Hey, it was suggested on Slack, that I raise a PR to add a link to the implementations page for a new performance benchmark & functionality comparison microsite we've created while trying to decide which JVM based validator implementation to use.

Site: https://www.creekservice.org/json-schema-validation-comparison/
Repo: https://github.com/creek-service/json-schema-validation-comparison

The site is designed to be auto-updating, via GitHub dependabot, as new versions of implementations are released. Contribution from implementation developers is encouraged.

Hey, it was suggested on [Slack](https://json-schema.slack.com/archives/C5CF75URH/p1697889828358549), that I raise a PR to add a link to the implementations page for a new performance benchmark & functionality comparison microsite we've created while trying to decide which JVM based validator implementation to use.

Site: https://www.creekservice.org/json-schema-validation-comparison/
Repo: https://github.com/creek-service/json-schema-validation-comparison

The site is designed to be auto-updating, via GitHub dependabot, as new versions of implementations are released.
Contribution from implementation developers is encouraged.
@big-andy-coates
Copy link
Contributor Author

I also wanted to mention that I've previously never noticed the Benchmarks section when I've been researching which JVM based validator implementation to use.

I was therefore also wondering if there was some way we could add a link from the list of validators at the top of the page to the associated benchmark section.

For example, add a link by the Java, Kotlin and Scala heading to the JVM section under Benchmarking. The same could be done for the existing PHP and JavaScript sections.

What do you think? Worth raising in an issue?

@benjagm
Copy link
Collaborator

benjagm commented Nov 16, 2023

I was therefore also wondering if there was some way we could add a link from the list of validators at the top of the page to the associated benchmark section.

Thanks a lot for this PR @big-andy-coates ! Your have done an amazing job with your tool and I am happy the community using Java will love it. We are working in a total rebuild of this page on this issue #160 . Do you mind sharing this feedback there? I am concerned that this won't be easy to implement in the new version that will be totally data-driven with filters so all implementation types has the same consideration. The good thing in the new approach is users using java will be able to filter by java and see all the options available for their needs, including benchmark.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your tool. I think is super cool what you have done!

@benjagm benjagm merged commit c315d99 into json-schema-org:main Nov 20, 2023
@big-andy-coates big-andy-coates deleted the add-creek-benchmark branch November 20, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants