Add 'Create New Template' button to Presets tab #22
Conversation
- Renamed 'Save Current' button to 'Create New Template' for clarity - Updated dialog title from 'Save Current Configuration' to 'Create New Template' - Changed navigation title to 'Create Template' - Updated default template name from 'Preset' to 'Template' - Changed button label from 'Save' to 'Create' in the dialog - Added helpful tooltip explaining the button's purpose This makes it clearer to users how to create new templates/presets.
Summary of ChangesHello @jsonify, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user experience for creating new templates by standardizing terminology and improving clarity across various UI elements. The changes focus on renaming buttons, dialog titles, and default text to consistently use 'Template' instead of 'Preset' or 'Save Current', thereby making the template creation process more intuitive and understandable for users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves clarity by renaming UI elements for creating a new preset to use the term 'template'. The changes are consistent and make the user flow more intuitive. I've added a couple of suggestions to further improve consistency, both in the UI and in the code, to fully align with the new terminology.
| } | ||
| .buttonStyle(.borderedProminent) | ||
| .disabled(viewModel.isRunning) | ||
| .help("Create a new preset from current settings") |
There was a problem hiding this comment.
The new tooltip is helpful, but it uses the term 'preset' while the button label and the rest of the creation dialog now use 'template'. For consistency, it would be better to use 'template' in the tooltip as well.
| .help("Create a new preset from current settings") | |
| .help("Create a new template from current settings") |
| TextField("Preset Name", text: $newPresetName) | ||
|
|
||
| TextField("Template Name", text: $newPresetName) |
There was a problem hiding this comment.
While the UI placeholder is now correctly set to 'Template Name', the underlying state variable is still newPresetName. To improve code consistency and maintainability, I recommend renaming this variable to newTemplateName. Similarly, the saveCurrentPreset() function, which is called when creating the template, could be renamed to something like createTemplate() to align the code with the new UI terminology.
This makes it clearer to users how to create new templates/presets.