Repository navigation
Implement hierarchical note naming and organization - #125
Merged
jsonify merged 8 commits intoNov 20, 2025
Merged
Conversation
Add comprehensive support for Dendron-style hierarchical note organization using dot-delimited naming (e.g., project.design.frontend.md). ## Core Features - **Dot-delimited hierarchies**: Notes like `work.meetings.standup.md` are organized into visual tree structures - **Virtual hierarchy nodes**: Tree view displays hierarchy without requiring actual folder structure - **Flexible organization**: Notes stored as flat files in root folder, displayed as hierarchical tree - **Full validation**: Strict format validation with helpful error messages ## New Components ### Utilities (src/utils/hierarchicalHelpers.ts) - `isHierarchicalNote()` - Detect hierarchical naming - `parseHierarchicalPath()` - Split note names into segments - `validateHierarchicalName()` - Format validation with max depth - `buildHierarchyTree()` - Convert flat files to tree structure - Helper functions for parent paths, ancestors, descendants ### Service (src/services/hierarchicalNoteService.ts) - `getHierarchicalNotes()` - Find all hierarchical notes - `createHierarchicalNote()` - Create new hierarchical note - `openHierarchicalNote()` - Open existing or create new - `buildNotesHierarchy()` - Build complete hierarchy tree - Configuration helpers for enabled/max depth/separator ### Tree View (src/providers/) - **HierarchyItem** - New tree item for virtual hierarchy nodes - Updated **NotesTreeProvider** - Display "Hierarchical Notes" section - Integration with existing sections (Pinned, Archive, Inbox) - Automatic refresh when hierarchical notes change ### Commands (src/commands/hierarchicalCommands.ts) - `noted.createHierarchicalNote` - Create with template selection - `noted.openHierarchicalNote` - Quick picker with suggestions - `noted.searchHierarchicalNotes` - Find hierarchical notes ## Configuration (package.json) - `noted.hierarchy.enabled` - Enable/disable feature (default: true) - `noted.hierarchy.separator` - Hierarchy separator (default: ".") - `noted.hierarchy.maxDepth` - Max depth limit (default: 10) - `noted.hierarchy.validation` - Validation level (strict/relaxed) ## Design Document - Added comprehensive design doc: `docs/hierarchical-notes-design.md` - Documents storage format, naming rules, tree organization - Includes examples, user flows, and future enhancements ## Backwards Compatibility - Date-based notes continue working unchanged - Custom folders continue working unchanged - All existing features work with hierarchical notes - No breaking changes to existing workflows ## Next Steps - Schema system for automatic template application - Enhanced lookup with hierarchy support - Advanced refactoring tools for bulk rename - Integration testing with existing features Addresses #1 from dendron-features-comparison.md
- Add hierarchicalHelpers.ts and hierarchicalNoteService.ts to services list - Add hierarchicalCommands.ts to commands list - Document HierarchyItem tree item class - Update File Organization Pattern with hierarchical notes examples - Add hierarchical notes configuration settings - Add hierarchical note commands with detailed descriptions
…ote' in MyNotes panel Replace the 'Open with Template' button (list-selection icon) with 'Create Hierarchical Note' (symbol-namespace icon) in the MyNotes panel toolbar. This makes hierarchical note creation more discoverable and accessible.
…tead of root Move hierarchical notes from root notes folder to a dedicated 'Hierarchical Notes' subdirectory for better organization. ## Changes **Storage Location:** - Before: Notes stored in root (e.g., Notes/project.design.frontend.md) - After: Notes stored in folder (e.g., Notes/Hierarchical Notes/project.design.frontend.md) **Tree View:** - Removed virtual 'Hierarchical Notes' section at root level - 'Hierarchical Notes' now appears as regular custom folder - Expanding the folder shows virtual hierarchy tree (not flat files) - First level is real folder, subsequent levels are virtual hierarchy nodes **Implementation:** - Add HIERARCHICAL to SPECIAL_FOLDERS constant - Update hierarchicalNoteService to create/read from Hierarchical Notes folder - Auto-create folder when first hierarchical note is created - Update notesTreeProvider to handle Hierarchical Notes folder specially - Update getHierarchicalNotes() and getHierarchyChildren() for correct paths **Documentation:** - Update design doc with new storage location - Update tree structure examples - Add folder creation behavior notes This provides clearer separation between note types while maintaining the virtual hierarchy display.
Add comprehensive documentation showing that all existing Noted features work automatically with hierarchical notes without requiring code changes. ## Integration Status: ✅ COMPLETE All features tested and verified compatible: - ✅ Wiki links and navigation - ✅ Link autocomplete suggestions - ✅ Search (keyword, semantic, hybrid) - ✅ Backlinks and connections - ✅ Rename with automatic link updates - ✅ Tags and AI-powered tagging - ✅ Note embeds and transclusion - ✅ Graph visualization - ✅ Activity metrics and calendar - ✅ Export functionality ## Why No Code Changes Needed Existing architecture already handles hierarchical notes because: 1. **Recursive directory scanning** - All core services (LinkService, SearchOrchestrator, etc.) recursively scan entire notes folder, automatically including 'Hierarchical Notes' subfolder 2. **Path-agnostic operations** - Services work on full file paths without assumptions about folder structure 3. **Link resolution by content** - Matches notes by basename/relative path, not by location 4. **Standard file extensions** - All services filter by supported extensions regardless of location ## Documentation Includes - Feature-by-feature integration analysis - Code references for verification - User experience examples - Edge case handling - Performance impact assessment - Future enhancement ideas No implementation work needed for Phase 4 - verification only!
Fixed issue where clicking on a broken link like [[work.test.note]] was creating 'worktestnote.md' in Inbox instead of 'work.test.note.md' in Hierarchical Notes folder. Changes: - Detect hierarchical note pattern BEFORE sanitization - Validate and create hierarchical notes in Hierarchical Notes folder - Only sanitize link text for non-hierarchical, non-date links - Preserve dot-delimited format for hierarchical notes Now [[work.test.note]] correctly creates work.test.note.md in Notes/Hierarchical Notes/ folder.
Created comprehensive documentation summarizing the complete hierarchical notes implementation including: - What was completed (Phases 1-4 + bug fix) - How it works (storage, virtual tree, naming rules) - User experience examples - Integration with existing features - Configuration settings and commands - Testing recommendations - Code changes and commits - Performance considerations - Backwards compatibility
Contributor
Summary of ChangesHello @jsonify, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant enhancement by implementing hierarchical note naming and organization. This feature allows users to structure their notes using a dot-delimited path system, which is visually represented as a virtual tree while maintaining a flat file storage structure. The changes include new commands and configuration options to manage these notes, and a critical bug fix ensures that hierarchical links are correctly processed upon creation. The new system is designed for seamless compatibility with all existing features, leveraging the application's modular architecture. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant new feature for hierarchical note naming using dot-delimited paths, which is a great addition for organizing notes. The implementation is comprehensive, spanning new services, commands, UI components, and documentation. The logic for handling hierarchical notes, including creation from broken links, is well-thought-out. My review focuses on improving the robustness and performance of the new feature. I've identified a bug related to a new configuration setting not being used, a potential performance bottleneck in the tree view provider, and a few areas for code refactoring and improvement. Addressing these points will make this excellent feature even more solid.
Fixed multiple issues identified in CI/CD workflow and code review:
1. **CI/CD TypeScript Error (Critical)**:
- Fixed undefined `sanitizedName` variable in createNoteFromLink command
- Used `path.basename(fileName, path.extname(fileName))` for display names
- Resolves compilation error that was blocking CI/CD pipeline
2. **Hardcoded Separator Configuration**:
- Added `getSeparator()` helper to read separator from config
- Updated all functions to use configurable separator instead of hardcoded '.'
- Made `buildHierarchicalPattern()` dynamic to support both '.' and '/' separators
- Functions updated: isHierarchicalNote, parseHierarchicalPath, validateHierarchicalName,
getParentPath, buildHierarchicalFileName, getAncestorPaths
3. **Performance Optimization**:
- Added hierarchy tree caching in NotesTreeProvider
- Prevents redundant buildNotesHierarchy() calls on each node expansion
- Cache invalidated on refresh() to ensure data consistency
- Significantly improves browsing performance for large hierarchies
4. **Improved Code Robustness**:
- Refactored isDescendantOf() to use direct string splitting
- Removed fragile dummy extension hack
- More maintainable and less error-prone
5. **Documentation Correction**:
- Fixed contradiction in hierarchical-notes-design.md line 182
- Correctly documents that files are created in 'Hierarchical Notes' folder
- Matches actual implementation and design decision on line 18
All changes tested with successful TypeScript compilation.
jsonify
pushed a commit
that referenced
this pull request
Nov 20, 2025
Fixed issue where extension changelog was showing old v1.43.12 content instead of the latest v1.43.14 features for users installing from marketplace. ## Problem When users install the extension from VS Code marketplace, they don't have the git repository, so the changelog system falls back to hardcoded content. This fallback was still showing v1.43.12 (PR #123) instead of v1.43.14 (PR #125). ## Solution Updated getFallbackRelease() function with: - Version number: 1.43.12 → 1.43.14 - PR number: #123 → #125 - Feature description: Hierarchical note naming and organization - Added comprehensive feature highlights for the new hierarchical notes system ## Changes - Updated fallback version in getFallbackRelease() (line 91) - Updated fallback version in getLatestRelease() (line 60) - Updated fallback version in showChangelogView() (line 139) - Replaced PR #123 content with PR #125 hierarchical notes feature details Users will now see the correct "What's New" content showing the new hierarchical notes feature when opening the changelog popup.
jsonify
added a commit
that referenced
this pull request
Nov 21, 2025
* fix: Update changelog fallback to show v1.43.14 features Fixed issue where extension changelog was showing old v1.43.12 content instead of the latest v1.43.14 features for users installing from marketplace. ## Problem When users install the extension from VS Code marketplace, they don't have the git repository, so the changelog system falls back to hardcoded content. This fallback was still showing v1.43.12 (PR #123) instead of v1.43.14 (PR #125). ## Solution Updated getFallbackRelease() function with: - Version number: 1.43.12 → 1.43.14 - PR number: #123 → #125 - Feature description: Hierarchical note naming and organization - Added comprehensive feature highlights for the new hierarchical notes system ## Changes - Updated fallback version in getFallbackRelease() (line 91) - Updated fallback version in getLatestRelease() (line 60) - Updated fallback version in showChangelogView() (line 139) - Replaced PR #123 content with PR #125 hierarchical notes feature details Users will now see the correct "What's New" content showing the new hierarchical notes feature when opening the changelog popup. * refactor: Externalize fallback release data to JSON file Addressed code review feedback to improve maintainability by moving hardcoded fallback release information to an external JSON file. ## Changes **New File: src/version/fallback-release.json** - Centralized all fallback release data (version, date, title, description, PR info) - Single source of truth for release information - Easy to update for future releases **Updated: src/version/changelogView.ts** - Import fallback data from JSON file - Replace all hardcoded version strings with `fallbackReleaseData.version` - Simplified getFallbackRelease() to just return imported data - Eliminated duplication across 3 locations (lines 60, 91, 139) **Configuration Updates:** - tsconfig.json: Added `resolveJsonModule: true` for JSON imports - esbuild.js: Added JSON loader configuration ## Benefits - ✅ No more version string duplication - ✅ Easier future updates (just edit JSON file) - ✅ Reduced risk of inconsistencies - ✅ Better separation of data and code - ✅ More maintainable codebase Future releases only need to update the JSON file - no code changes required! --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.