Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: using node14 with type:module #434

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat!: using node14 with type:module #434

wants to merge 1 commit into from

Conversation

antialias
Copy link
Contributor

No description provided.

@antialias antialias mentioned this pull request Nov 28, 2020
Closed
@antialias antialias changed the title using node14 with type:module feat!: using node14 with type:module Nov 28, 2020
rbardini
rbardini reviewed Nov 29, 2020
View reviewed changes
.github/workflows/main.yml
@@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14]
node: [14.15.1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only one version is tested, a matrix is not needed. But it may still be useful to test in different Node.js versions.

Also, I believe 14 would use the latest 14 version, so we don't need to set the complete version. (same below and in .npmrc)

rbardini
rbardini reviewed Dec 1, 2020
View reviewed changes
package.json
@@ -3,8 +3,9 @@
"version": "0.0.0-development",
"description": "The JSON Resume command line interface",
"main": "index.js",
"type": "module",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the published package.json once we compile the source with Babel? Not sure anyone is importing resume-cli, but still.

@rbardini
Copy link
Contributor

rbardini commented Dec 1, 2020

I believe this is not a breaking change if we merge #433 first.

thomasdavis
thomasdavis approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@thomasdavis thomasdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just keep the testing on multiple node versions for now, see how it goes with the babel PR.

@antialias
Copy link
Contributor Author

setting this to "draft" because it appears that jest is still working on support for ES6 modules, and my attempts to get it working using experimental flags have so far been unsuccessful.

relevant jest issue here: jestjs/jest#9430

@antialias antialias marked this pull request as draft December 17, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbardini rbardini rbardini left review comments

@thomasdavis thomasdavis thomasdavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antialias @rbardini @thomasdavis