Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create filter to turn default youtube embed links into noocookie ones #15

Closed
javorszky opened this issue Feb 10, 2021 · 1 comment · Fixed by #19
Closed

Create filter to turn default youtube embed links into noocookie ones #15

javorszky opened this issue Feb 10, 2021 · 1 comment · Fixed by #19
Assignees
@javorszky

Comments

@javorszky
Copy link
Member

Source: #13 (review)

Turn

https://www.youtube.com/embed/m8iMGFjVgGg

into

https://www.youtube-nocookie.com/embed/m8iMGFjVgGg

Make a filter for it per https://www.11ty.dev/docs/filters/
@javorszky javorszky self-assigned this Feb 10, 2021
@javorszky javorszky mentioned this issue Feb 10, 2021
Merged
@omgmog
Copy link
Member

omgmog commented Feb 10, 2021 •
edited
Loading

Also handle these sort of links:

https://www.youtube.com/watch?v=m8iMGFjVgGg

to become:

https://www.youtube-nocookie.com/embed/m8iMGFjVgGg

Also yeah the filter should be straight forward to setup, examples of the ones I've added are here: https://github.com/jsoxford/jsnotoxfordsite/blob/main/.eleventy.js#L29-L43

They are then just used when outputting a value, e.g. you might have a filter called yt and use it like:

{{ stream | yt }}

@javorszky javorszky mentioned this issue Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javorszky javorszky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add yt shortcode for more flexibility jsoxford/jsnotoxfordsite
2 participants
@omgmog @javorszky