Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use youtube nocookie links instead #13

Merged
merged 1 commit into from
Feb 10, 2021
Merged

use youtube nocookie links instead #13

merged 1 commit into from
Feb 10, 2021

Conversation

javorszky
Copy link
Member

maybe fix the embeds?

omgmog
omgmog approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@omgmog omgmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As an aside I think I might add a filter to convert regular YouTube URLs to YouTube-nocookie automatically, so we could just dump the regular /watch?v= url in there and have it turn it into an embed url.

@javorszky javorszky mentioned this pull request Feb 10, 2021
Closed
@javorszky
Copy link
Member Author

Good idea! I'll try my hand at writing a filter for this :)

Opened #15

@javorszky javorszky merged commit 8dfa4ad into main Feb 10, 2021
@javorszky javorszky deleted the yt2-link2 branch February 10, 2021 20:55
@javorszky javorszky mentioned this pull request Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omgmog omgmog omgmog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javorszky @omgmog