Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title to page template #12

Merged
merged 1 commit into from
Feb 10, 2021
Merged

add title to page template #12

merged 1 commit into from
Feb 10, 2021

Conversation

javorszky
Copy link
Member

@javorszky javorszky commented Feb 10, 2021

static pages lost their titles, this adds them back

Copy link
Member

@omgmog omgmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to wrap an {% if %} around the whole <h1>?

@javorszky
Copy link
Member Author

I would feel more comfortable if there was a thing that said "hey this is a page that doesn't have a title, or has an empty title" and fail the build

@omgmog
Copy link
Member

omgmog commented Feb 10, 2021

I would feel more comfortable if there was a thing that said "hey this is a page that doesn't have a title, or has an empty title" and fail the build

Actually yeah that's a good point.

I also forgot for a moment that the new event.njk doesn't use the page layout, it uses base, so my worry is not a problem 👍

@javorszky javorszky merged commit 43015b6 into main Feb 10, 2021
@javorszky javorszky deleted the add-title-to-page branch February 10, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants