Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer on all pages #18

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Footer on all pages #18

merged 2 commits into from
Feb 11, 2021

Conversation

javorszky
Copy link
Member

@javorszky javorszky commented Feb 11, 2021

Previously only the main page and the coc had a footer, the individual (past) events did not.

This change makes sure that the footer is present in all instances.

@omgmog I remember you said something about the footer being present everywhere, but can't remember now, but would love to make sure that I'm not undoing something you did on purpose previously :)

This is also needed to get the open source thing from netlify (have the netlify badge in the footer on all pages)

@javorszky javorszky requested a review from omgmog February 11, 2021 21:18
Copy link
Member

@omgmog omgmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I had in mind :shipit:

@omgmog omgmog merged commit e108b3e into main Feb 11, 2021
@omgmog omgmog deleted the footer-on-all-pages branch February 11, 2021 21:36
@omgmog omgmog mentioned this pull request Feb 11, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants