Site preview images and some other metadata bits #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 |
|
Looks like the meta descriptions could do with an added Don't merge this until I've pushed a commit for that |
omgmog
commented
Feb 15, 2021
|
Oh I did not mean to push that, bare with 💯 |
…-images to use it correctly
omgmog
force-pushed
the
og-preview-images
branch
from
f3e3623 to
d6bff90
Compare
|
I think this is ready for a review 👍 |
javorszky
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give us working
/preview/XYZ.pngpreviews for use on Twitter and other social shares.These are generated automatically 🎉
This will make tweets like this: https://twitter.com/JSOxford/status/1359148138204966916 look a lot COOLER 😎