Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the "previous value or null" type of Properties.compute as nullable. #117

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Dec 19, 2024

This matches what we have for
Map.compute
,
noting that Properties is a Hashtable<Object, Object> and so a
Map<Object, Object>.

See previous discussion in
#114 (comment)

…ullable.

This matches [what we have for
`Map.compute`](https://github.com/jspecify/jdk/blob/7cc2fbd5f404bf5403bd1375b47024a855838fef/src/java.base/share/classes/java/util/Map.java#L1247),
noting that `Properties` is a `Hashtable<Object, Object>` and so a
`Map<Object, Object>`.

See previous discussion in
#114 (comment)
Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpovirk cpovirk merged commit 7630b5d into main Dec 19, 2024
19 checks passed
@cpovirk cpovirk deleted the cross-properties branch December 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants