Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept a null array of parameter types for more methods. #98

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Accept a null array of parameter types for more methods. #98

merged 1 commit into from
Oct 7, 2024

Conversation

cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Oct 4, 2024

We already do this for getMethod. In fairness, getMethod has clear
docs about it. These other methods do not. Still, I think that
@Nullable is justified, as I discussed in
#96

Fixes #96

@cpovirk
Accept a null array of parameter types for more methods.
957c818 
We already do this for `getMethod`. In fairness, `getMethod` has clear
docs about it. These other methods do not. Still, I think that
`@Nullable` is justified, as I discussed in
#96

Fixes #96
wmdietl
wmdietl approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cpovirk cpovirk merged commit cebb603 into main Oct 7, 2024
18 of 30 checks passed
@cpovirk cpovirk deleted the classnullarray branch October 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

Assignees

@cpovirk cpovirk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve Class.getMethod @Nullable parameterTypes vs. getMethod and getDeclared* (not annotated @Nullable)
2 participants
@cpovirk @wmdietl