Skip to content

Commit

Permalink
build: avoid useless configure-time checks
Browse files Browse the repository at this point in the history
Checking for the sizeof various types and defining preprocessor macros
for them, is pointless, since the *only* effect these had was defining
said macros... and the code never did anything with them.

This speeds up running configure and is less confusing to readers. It's
also less confusing to porters, as evidenced by the VS projects which
contain out of date copies of the config.h files that are missing some
of these unused checks.
  • Loading branch information
eli-schwartz authored and jstedfast committed Apr 28, 2023
1 parent 966dbae commit c376dc9
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 27 deletions.
9 changes: 0 additions & 9 deletions build/vs2008/config-win32.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,6 @@
/* Define to the version of this package. */
#define PACKAGE_VERSION "@GMIME_VERSION@"

/* The size of `off_t', as computed by sizeof. */
#define SIZEOF_OFF_T 4

/* The size of `size_t', as computed by sizeof. */
#define SIZEOF_SIZE_T 4

/* The size of `ssize_t', as computed by sizeof. */
#define SIZEOF_SSIZE_T 4

/* Define to 1 if you have the ANSI C header files. */
#define STDC_HEADERS 1

Expand Down
9 changes: 0 additions & 9 deletions build/vs2010/config-win32.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,6 @@
/* Define to the version of this package. */
#define PACKAGE_VERSION "@GMIME_VERSION@"

/* The size of `off_t', as computed by sizeof. */
#define SIZEOF_OFF_T 4

/* The size of `size_t', as computed by sizeof. */
#define SIZEOF_SIZE_T 4

/* The size of `ssize_t', as computed by sizeof. */
#define SIZEOF_SSIZE_T 4

/* Define to 1 if you have the ANSI C header files. */
#define STDC_HEADERS 1

Expand Down
9 changes: 0 additions & 9 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -440,15 +440,6 @@ else
fi
AM_CONDITIONAL(ENABLE_LARGEFILE, test "x$enable_largefile" = "xyes")

dnl Check type sizes
CFLAGS_save="$CFLAGS"
CFLAGS="$CFLAGS $LFS_CFLAGS"
AC_CHECK_SIZEOF(ssize_t)
AC_CHECK_SIZEOF(size_t)
AC_CHECK_SIZEOF(off_t)
AC_CHECK_SIZEOF(time_t)
CFLAGS="$CFLAGS_save"

dnl Check for some network functions
AC_CHECK_FUNCS(gethostname getdomainname getaddrinfo)

Expand Down

0 comments on commit c376dc9

Please sign in to comment.