-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transloco): add intlmessageformat transpiler #649
base: master
Are you sure you want to change the base?
Conversation
Adding an alternative messageformat transpiler based on formatjs/intlmessageformat white_check_mark Closes: jsverse#364 Signed-off-by: isc-auf <[email protected]>
Run & review this pull request in StackBlitz Codeflow. |
|
@shaharkazaz the other PR was merged, do we want to go on with this one? |
hello @f-aubert @shaharkazaz do we have any update on this? I also cannot ship with unsafe-eval and I use MessageFormat. |
@shaharkazaz any update on this one? I'd gladly help some more |
@f-aubert Hi! sorry for not being here for a while, a lot going on both personally and nationally. |
Adding an alternative messageformat transpiler based on formatjs/intlmessageformat
white_check_mark Closes: #364
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Transloco MessageFormatTranspiler may lead to CSP Problems due to usage (in messageformat.js) of the eval function.
Issue Number: #364
What is the new behavior?
Provide an alternative IntlMessaeFormatTranspiler based on formatjs/intl(messageformat)
Does this PR introduce a breaking change?
Other information
I'd gladly discuss it with you as I'm not an expert in packaging libs! I also inspired myself a lot from your MessageFormatTranspiler. Thanks.