Fix Icon not being DOMWidget

jtpio · Jan 31, 2024 · 8f173ab · 8f173ab
1 parent 9711add
commit 8f173ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/examples/generic.ipynb b/examples/generic.ipynb
@@ -37,8 +37,10 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "import ipylab\n",
     "import ipywidgets as ipw\n",
+    "\n",
+    "import ipylab\n",
+    "\n",
     "app = ipylab.JupyterFrontEnd()"
    ]
   },
@@ -315,7 +317,7 @@
     }
    ],
    "source": [
-    "widget = ipw.HTML('<h3>Hello world</h3>')\n",
+    "widget = ipw.HTML(\"<h3>Hello world</h3>\")\n",
     "widget"
    ]
   },
@@ -374,7 +376,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "t = app.getAttribute('views', widget=widget)"
+    "t = app.getAttribute(\"views\", widget=widget)"
    ]
   },
   {

diff --git a/ipylab/widgets.py b/ipylab/widgets.py
@@ -6,7 +6,7 @@
 import asyncio
 
 import ipywidgets as ipw
-from ipywidgets import Box, Layout, register, widget_serialization
+from ipywidgets import Box, DOMWidget, Layout, register, widget_serialization
 from ipywidgets.widgets.trait_types import InstanceDict
 from traitlets import Bool, Dict, Unicode
 
@@ -17,7 +17,7 @@
 
 
 @register
-class Icon(WidgetBase):
+class Icon(DOMWidget, WidgetBase):
     _model_name = Unicode("IconModel").tag(sync=True)
     _view_name = Unicode("IconView").tag(sync=True)