fix: tagged enum with flatten fields #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any progress on this? We need this PR to be merged. |
juhaku
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Seems good to me, could you add a CHANGLOG entry in utoipa-gen for the change.
Here is example format of what should be added at the very top of the CHANGELOG.md
## Unreleased
### Changed
* title (http://PR)Is there any progress on this? We need this PR to be merged.
Sure, I have been quite busy with life recently.
|
@juhaku done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1206
This is a quick solution to the problem; the coding style might not align with conventional standards, but I am ready to address any shortcomings.