scripts/test.sh: Fix auto_into_responses feature declaration
#1252
Conversation
…ations and comment out broken tests
These invocations weren't actually running the corresponding tests
Turbo87
force-pushed
the
broken-tests
branch
from
bac9acf to
f81593d
Compare
Yup, It's quite long ago, since that feature was on the table. 😅 Thus no wonder if there are some tests that does not work as expected. So I agree we can merge this as is in slightly broken state and whenever the automatic responses will be looked again, it is more likely beneficial start fresh while keeping the original attempt as a reference. Anyhow that is something for some unknown future 😄 I believe that probably no one has ever used that feature. |
utoipa-gen/CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| ### Changed | |||
|
|
|||
| * scripts/test.sh: Fix `auto_into_responses` feature declaration (https://github.com/juhaku/utoipa/pull/1252) | |||
There was a problem hiding this comment.
Otherwise great, but should be under new title Unreleased and subtitle Changed at the top before 5.3.0
There was a problem hiding this comment.
oops, I missed that this was for a released version 😅
Turbo87
force-pushed
the
broken-tests
branch
from
f81593d to
5e90b05
Compare
#665 renamed the feature, but for some reason the
test.shscript containedutoipa/prefixes for the feature name in some cases, which effectively disabled these tests from even getting compiled.This PR fixes the feature name in the
cargo testinvocations and "fixes" the actix tests as best as I was able to. Two tests weren't compiling at all, and another couple of tests were resulting in different output than the test was expecting. This should probably be fixed properly by someone with more knowledge of actix than me, but since it's already broken onmasterI guess we may as well merge it in this slightly less broken state 😅