-
Notifications
You must be signed in to change notification settings - Fork 0
Features/modules #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Features/modules #126
Changes from 8 commits
c2273a9
08c2553
6e2fbc5
a4ecc56
e9541ab
f1173af
f911fd2
44dab99
d2da5df
6f3157f
0f9a017
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-parent</artifactId> | ||
| <version>3.8.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>steve-bom</artifactId> | ||
| <packaging>pom</packaging> | ||
|
|
||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-core</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-jooq</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-ocpp-commons</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-ocpp-1-x</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-ocpp-2-x</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-ocpp-transport-soap</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-ocpp-transport-websocket</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-api</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>de.rwth.idsg</groupId> | ||
| <artifactId>steve-ui-jsp</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>com.diffplug.spotless</groupId> | ||
| <artifactId>spotless-maven-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,8 @@ | |
| import org.springframework.boot.context.properties.ConfigurationProperties; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| import java.time.Duration; | ||
|
|
||
| /** | ||
| * @author Sevket Goekay <sevketgokay@gmail.com> | ||
| * @since 19.08.2014 | ||
|
|
@@ -84,5 +86,13 @@ public static class Ocpp { | |
| private boolean autoRegisterUnknownStations; | ||
| private @Nullable String chargeBoxIdValidationRegex; | ||
| private String wsSessionSelectStrategy; | ||
| private Ws ws = new Ws(); | ||
|
|
||
| @Data | ||
| public static class Ws { | ||
| private @Nullable Integer maxTextMessageSize; | ||
| private @Nullable Duration idleTimeout; | ||
| private String[] allowedOriginPatterns; | ||
| } | ||
|
Comment on lines
+89
to
+106
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major 🧩 Analysis chainVerify WebSocket configuration migration completeness. The new Ensure all WebSocket configuration from the removed class has been migrated to these properties and verify that the consuming code has been updated accordingly. 🏁 Script executed: #!/bin/bash
# Verify that OcppWebSocketConfiguration has been removed and check for any remaining references
# Check if OcppWebSocketConfiguration still exists
echo "=== Checking if OcppWebSocketConfiguration exists ==="
fd -t f -e java OcppWebSocketConfiguration
# Search for references to the old configuration class
echo "=== Searching for references to OcppWebSocketConfiguration ==="
rg -n "OcppWebSocketConfiguration" --type java
# Search for usages of the new Ws configuration
echo "=== Searching for usages of new Ws properties ==="
rg -n "\.ws\.(maxTextMessageSize|idleTimeout|allowedOriginPatterns)" --type java -A2 -B2Length of output: 1047 Migrate OcppWebSocketConfiguration to use SteveProperties.Ws 🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.