Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

allow the vagrant box to be configurable #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmerickel
Copy link
Contributor

No description provided.

@bfirsh
Copy link
Collaborator

bfirsh commented May 18, 2014

What's the use of this? docker-0.8.0 is the only box that exists.

@mmerickel
Copy link
Contributor Author

Ah well I had a box that's still using the docker-0.7.2 image and encountered some errors when using the newer scripts, so I used this to stay on 0.7.2 for now. The main issue is that the VAGRANT_BOX_URL param introduced in #57 wasn't really useful without this part.

@bfirsh
Copy link
Collaborator

bfirsh commented May 21, 2014

Ah, okay. You should in theory be able to set VAGRANT_BOX_URL to http://static.orchardup.com/binaries/vagrant/vagrant-docker-0.7.2-virtualbox.box?

@mmerickel
Copy link
Contributor Author

Right, but without this PR you cannot tell docker-osx to boot a different box since the URL is only used when your machine doesn't have a box downloaded named docker-0.8.0 right now.

@bfirsh
Copy link
Collaborator

bfirsh commented May 22, 2014

Ah sorry, I understand what you mean. Perhaps we could just rename the box "docker" – once you've downloaded it, it automatically updates the Docker version for you.

@freewil
Copy link

freewil commented Jun 19, 2014

👍 I don't have an immediate use for this, but I could see it being useful to be able to use two different versions of Docker.

@mmerickel
Copy link
Contributor Author

I've rebased this onto master. If you'd like to rename the box to "docker" that's fine but it's orthogonal to this PR which allows someone to use any box if necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants