Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] debug failure on v1.11 #3843

Merged
merged 5 commits into from
Oct 9, 2024
Merged

[docs] debug failure on v1.11 #3843

merged 5 commits into from
Oct 9, 2024

Conversation

odow
Copy link
Member

@odow odow commented Oct 8, 2024

Doc build is currently failing on 1.11

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (678e7d5) to head (84a279f).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
+ Coverage   97.50%   97.54%   +0.03%     
==========================================
  Files          44       44              
  Lines        6017     6017              
==========================================
+ Hits         5867     5869       +2     
+ Misses        150      148       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Oct 9, 2024

So it seems like the TSP tutorial has broken. I have no idea why

@odow
Copy link
Member Author

odow commented Oct 9, 2024

My conclusion is that the lazy constraint algorithm in GLPK adds local lazy, so it's just pretty terrible at repeating existing work.

@blegat
Copy link
Member

blegat commented Oct 9, 2024

Maybe we should use SCIP instead of GLPK but looking at SCIP.jl, it supports MOI.HeuristicCallback and MOI.UserCutCallback but not MOI.LazyConstraintCallback. @matbesancon what is blocking SCIP.jl from adding support to the solver-agnostic lazy callback ?

@odow
Copy link
Member Author

odow commented Oct 9, 2024

Or we could just add Gurobi since we have a license now...

@matbesancon
Copy link
Contributor

matbesancon commented Oct 9, 2024 via email

@odow
Copy link
Member Author

odow commented Oct 9, 2024

This is sufficient for now. The tutorial changes were because of differences in Random number streams.

@odow odow merged commit 0a99d50 into master Oct 9, 2024
11 checks passed
@odow odow deleted the odow-patch-1 branch October 9, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants