Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHOT to list of supported solvers #3853

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add SHOT to list of supported solvers #3853

merged 2 commits into from
Oct 23, 2024

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 18, 2024

This doesn't check most of the item but it's the same as Couenne and BONMIN, I don't think the list applies to the solvers available through AMPLNLWriter

Basic

  • Check that the solver is a registered Julia package
  • Check that the solver supports the long-term support release of Julia
  • Check that the solver has a MathOptInterface wrapper
  • Check that the tests call MOI.Test.runtests. Some test excludes are
    permissible, but the reason for skipping a particular test should be
    documented.
  • Check that the README and/or documentation provides an example of how to
    use the solver with JuMP

Documentation

  • Add a new row to the table in docs/src/installation.md

Optional

  • Add package metadata to docs/packages.toml

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (4876764) to head (7411809).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3853   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          44       44           
  Lines        6027     6027           
=======================================
  Hits         5879     5879           
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Oct 18, 2024

I've previously held off adding it because of
https://github.com/jump-dev/AmplNLWriter.jl/blob/69220aff78bd769b164e960926a5947f568bff6d/test/MINLPTests/run_minlptests.jl#L72-L99

I should take another look.

@odow odow merged commit 0b1cd8f into master Oct 23, 2024
11 checks passed
@odow odow deleted the bl/shot branch October 23, 2024 21:04
@odow
Copy link
Member

odow commented Oct 23, 2024

It is what it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants