Skip to content

Fix nonlinear reformulation with range variables #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 1 commit into from
Dec 4, 2025
Merged

Fix nonlinear reformulation with range variables #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nonlinear.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function reformulate_as_nonlinear_program!(model::MOI.ModelLike; relaxation=0.0)
# Get bounds on x2
lb2, ub2 = MOIU.get_bounds(model, Float64, x2)
# x2 should have at least one bound, otherwise x1 becomes a fixed variable
@assert isinf(lb2) || isinf(ub2)
@assert isfinite(lb2) || isfinite(ub2)
quad_terms = [
MOI.ScalarQuadraticTerm(1.0, x1, x2)
]
Expand Down
3 changes: 2 additions & 1 deletion test/instances.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ end
# attributed to Hakonsen, L. "Essays on Taxation, Efficiency and the
# Environment", PhD thesis, Norwegian School of Economics & Business
# Administration, April 1998.
function hakonsen_model()
# TODO: require to add support for MOI.VectorNonlinearFunction
function hakonsen_model_broken()
L = 100.0
G = 25.0
pL = 1.0
Expand Down
1 change: 0 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ expected_models = Dict(

function test_model(model_func)
model = model_func()
model = Instances.fletcher_leyffer_ex1_model()
inner = MOI.Utilities.Model{Float64}()
set_optimizer(model, () -> ComplementOpt.Optimizer(inner))
MOI.Utilities.attach_optimizer(model)
Expand Down
Loading